From: Taylor Blau Date: Wed, 12 Jul 2023 23:38:00 +0000 (-0400) Subject: commit-graph.c: prevent overflow in `load_oid_from_graph()` X-Git-Tag: v2.42.0-rc0~39^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0bd8f30a0e4e474163eb2d8dc3020d51ec3c8a35;p=thirdparty%2Fgit.git commit-graph.c: prevent overflow in `load_oid_from_graph()` In a similar spirit as previous commits, ensure that we don't overflow when trying to compute an offset into the `chunk_oid_lookup` table when the `lex_index` of the item we're trying to look up exceeds `2^32-1/g->hash_len`. Signed-off-by: Taylor Blau Signed-off-by: Junio C Hamano --- diff --git a/commit-graph.c b/commit-graph.c index 17ab3e8029..517c816a94 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -754,7 +754,7 @@ static void load_oid_from_graph(struct commit_graph *g, lex_index = pos - g->num_commits_in_base; - oidread(oid, g->chunk_oid_lookup + g->hash_len * lex_index); + oidread(oid, g->chunk_oid_lookup + st_mult(g->hash_len, lex_index)); } static struct commit_list **insert_parent_or_die(struct repository *r,