From: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu, 10 Mar 2022 17:18:07 +0000 (+0000)
Subject: tests: print newline after QMP response in qtest logs
X-Git-Tag: v7.1.0-rc0~136^2~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0c2b6c85c99d8d2a957e6637c7cc0fd33f2b0540;p=thirdparty%2Fqemu.git

tests: print newline after QMP response in qtest logs

The QMP commands have a trailing newline, but the response does not.
This makes the qtest logs hard to follow as the next QMP command
appears in the same line as the previous QMP response.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220310171821.3724080-5-berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 7db7ef3a687..5098d71485c 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -612,10 +612,13 @@ QDict *qmp_fd_receive(int fd)
         }
 
         if (log) {
-            len = write(2, &c, 1);
+            g_assert(write(2, &c, 1) == 1);
         }
         json_message_parser_feed(&qmp.parser, &c, 1);
     }
+    if (log) {
+        g_assert(write(2, "\n", 1) == 1);
+    }
     json_message_parser_destroy(&qmp.parser);
 
     return qmp.response;