From: Ævar Arnfjörð Bjarmason Date: Tue, 5 Jan 2021 19:42:43 +0000 (+0100) Subject: mktag: use default strbuf_read() hint X-Git-Tag: v2.31.0-rc0~111^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0c439117bbc8f51b9c13b323ea7a9f76892a433d;p=thirdparty%2Fgit.git mktag: use default strbuf_read() hint Change the hardcoded hint of 2^12 to 0. The default strbuf hint is perfectly fine here, and the only reason we were hardcoding it is because it survived migration from a pre-strbuf fixed-sized buffer. See fd17f5b5f77 (Replace all read_fd use with strbuf_read, and get rid of it., 2007-09-10) for that migration. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/builtin/mktag.c b/builtin/mktag.c index 4982d3a93e..ff7ac8e0e5 100644 --- a/builtin/mktag.c +++ b/builtin/mktag.c @@ -161,7 +161,7 @@ int cmd_mktag(int argc, const char **argv, const char *prefix) if (argc != 1) usage("git mktag"); - if (strbuf_read(&buf, 0, 4096) < 0) { + if (strbuf_read(&buf, 0, 0) < 0) { die_errno("could not read from stdin"); }