From: Steve Holme <steve_holme@hotmail.com>
Date: Wed, 13 Feb 2013 18:22:20 +0000 (+0000)
Subject: smtp: Removed duplicate pingpong structure initialisation
X-Git-Tag: curl-7_30_0~357
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0c6fa0dd648a772dc2ef3dcae02a39190e55fd2a;p=thirdparty%2Fcurl.git

smtp: Removed duplicate pingpong structure initialisation

The smtp_connect() function was setting the member variables of the
pingpong structure twice, once before calling Curl_pp_init() and once
after!
---

diff --git a/lib/smtp.c b/lib/smtp.c
index 456d986aad..ad265f8924 100644
--- a/lib/smtp.c
+++ b/lib/smtp.c
@@ -1347,12 +1347,6 @@ static CURLcode smtp_connect(struct connectdata *conn, bool *done)
   /* Initialise the response reader stuff */
   Curl_pp_init(pp);
 
-  /* Set the default response time-out */
-  pp->response_time = RESP_TIMEOUT;
-  pp->statemach_act = smtp_statemach_act;
-  pp->endofresp = smtp_endofresp;
-  pp->conn = conn;
-
   /* Calculate the path if necessary */
   if(!*path) {
     if(!Curl_gethostname(localhost, sizeof(localhost)))