From: Alex <bigalex934@gmail.com>
Date: Mon, 4 Dec 2023 16:45:29 +0000 (+0000)
Subject: Fix configuration crashes on malformed sslproxy_* directives (#1603)
X-Git-Tag: SQUID_7_0_1~268
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0c7492095832c84aacdbc517ca263da7d8890614;p=thirdparty%2Fsquid.git

Fix configuration crashes on malformed sslproxy_* directives (#1603)
---

diff --git a/src/cache_cf.cc b/src/cache_cf.cc
index 929bf75c37..17b961ffa7 100644
--- a/src/cache_cf.cc
+++ b/src/cache_cf.cc
@@ -1119,6 +1119,9 @@ parse_obsolete(const char *name)
 
         // add the value as unquoted-string because the old values did not support whitespace
         const char *token = ConfigParser::NextQuotedOrToEol();
+        if (!token)
+            throw TextException(ToSBuf("missing required parameter for obsolete directive: ", name), Here());
+
         tmp.append(token, strlen(token));
         Security::ProxyOutgoingConfig.parse(tmp.c_str());
     }