From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 1 Nov 2024 23:38:08 +0000 (+0000)
Subject: Report all refreshCheck() outcomes and entry gist (#1932)
X-Git-Tag: SQUID_7_0_1~46
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0cc6c016adef89d3c2fff30c1ce69f6d7efe6f3d;p=thirdparty%2Fsquid.git

Report all refreshCheck() outcomes and entry gist (#1932)

All other refreshCheck() return statements already have a debugs().
Reporting StoreEntry gist helps find the right calls in busy proxy logs.
---

diff --git a/src/refresh.cc b/src/refresh.cc
index 3e48cc0861..81be28ae4b 100644
--- a/src/refresh.cc
+++ b/src/refresh.cc
@@ -265,7 +265,7 @@ refreshCheck(const StoreEntry * entry, HttpRequest * request, time_t delta)
     else if (request)
         uri = request->effectiveRequestUri();
 
-    debugs(22, 3, "checking freshness of URI: " << uri);
+    debugs(22, 3, "checking freshness of " << *entry << " with URI: " << uri);
 
     // age is not necessarily the age now, but the age at the given check_time
     if (check_time > entry->timestamp)
@@ -480,11 +480,14 @@ refreshCheck(const StoreEntry * entry, HttpRequest * request, time_t delta)
         }
 
 #endif
+        debugs(22, 3, "returning STALE_EXPIRES");
         return STALE_EXPIRES;
     }
 
-    if (sf.max)
+    if (sf.max) {
+        debugs(22, 3, "returning STALE_MAX_RULE");
         return STALE_MAX_RULE;
+    }
 
     if (sf.lmfactor) {
 #if USE_HTTP_VIOLATIONS