From: Caleb Connolly Date: Wed, 26 Mar 2025 12:24:08 +0000 (+0100) Subject: scsi: fix typo in setup_read_ext() X-Git-Tag: v2025.07-rc1~91^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0cd3c1e7d0201cf9e4dbcac1e0179604f4461062;p=thirdparty%2Fu-boot.git scsi: fix typo in setup_read_ext() This clears the 6th byte of cmd twice rather than setting the 9th byte to 0. Fix it. The only other command that sets the 9th byte is the 64-bit read, so this likely never caused issues in practise. Signed-off-by: Caleb Connolly Reviewed-by: Neil Armstrong --- diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index cd0b84c0622..34ac47c03ab 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c @@ -90,7 +90,7 @@ static void scsi_setup_read_ext(struct scsi_cmd *pccb, lbaint_t start, pccb->cmd[6] = 0; pccb->cmd[7] = (unsigned char)(blocks >> 8) & 0xff; pccb->cmd[8] = (unsigned char)blocks & 0xff; - pccb->cmd[6] = 0; + pccb->cmd[9] = 0; pccb->cmdlen = 10; pccb->msgout[0] = SCSI_IDENTIFY; /* NOT USED */ debug("scsi_setup_read_ext: cmd: %02X %02X startblk %02X%02X%02X%02X blccnt %02X%02X\n",