From: Dan Carpenter Date: Tue, 20 Aug 2024 13:43:46 +0000 (+0300) Subject: ice: Fix a 32bit bug X-Git-Tag: v6.12-rc1~232^2~208 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ce054f2b891afdd102c8bcc1fc57253c8964e40;p=thirdparty%2Fkernel%2Flinux.git ice: Fix a 32bit bug BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type. On 32 bit systems, unsigned long is a u32 and the mismatch between u32 and u64 will break things for the high 32 bits. Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop") Signed-off-by: Dan Carpenter Reviewed-by: Alexander Lobakin Link: https://patch.msgid.link/ddc231a8-89c1-4ff4-8704-9198bcb41f8d@stanley.mountain Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c index d5bcc266b01ec..dedf5e854e4b7 100644 --- a/drivers/net/ethernet/intel/ice/ice_parser_rt.c +++ b/drivers/net/ethernet/intel/ice/ice_parser_rt.c @@ -377,11 +377,11 @@ static void ice_pg_exe(struct ice_parser_rt *rt) static void ice_flg_add(struct ice_parser_rt *rt, int idx, bool val) { - rt->pu.flg_msk |= BIT(idx); + rt->pu.flg_msk |= BIT_ULL(idx); if (val) - rt->pu.flg_val |= BIT(idx); + rt->pu.flg_val |= BIT_ULL(idx); else - rt->pu.flg_val &= ~BIT(idx); + rt->pu.flg_val &= ~BIT_ULL(idx); ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Pending update for flag %d value %d\n", idx, val);