From: Jérôme Magnin <jmagnin@haproxy.com>
Date: Tue, 23 Jul 2019 21:23:16 +0000 (+0200)
Subject: REGTESTS: checks: exclude freebsd target for tcp-check_multiple_ports.vtc
X-Git-Tag: v2.1-dev2~275
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d00b544c3bdc9dc1796aca28bad46b3c1867184;p=thirdparty%2Fhaproxy.git

REGTESTS: checks: exclude freebsd target for tcp-check_multiple_ports.vtc

This patch excludes freebsd, osx and generic targets for this vtc.

Basic tcp checks performed by haproxy on a linux system leverage the
TCP_QUICKACK option which implies that the connection is never
established from the perspective of the backend server. On other systems
a regular tcp 3 way handshake is performed immediately followed by a
reset, which from the perspective of the server is an aborted connection.

When we run this regtest on FreeBSD (or anything other than linux) there
is a race condition in the server_thread() function of the vtc_server.c
file. If we receive the reset when we are in accept() then fd is -1 and
vtest calls vtc_fatal, failing the test.

Other checks specific reg-tests were excluded on FreeBSD, osx and
generic for the same reason, but were at the time documented as being
disabled because they used TCP_DEFER_ACCEPT. These commits are
15685c791 ("REGTEST: Exclude freebsd target for some reg tests") and
03c6ab0cb ("REGTEST: exclude osx and generic targets for
40be_2srv_odd_health_checks")
---

diff --git a/reg-tests/checks/tcp-check_multiple_ports.vtc b/reg-tests/checks/tcp-check_multiple_ports.vtc
index a61e9e8455..da380a3bb1 100644
--- a/reg-tests/checks/tcp-check_multiple_ports.vtc
+++ b/reg-tests/checks/tcp-check_multiple_ports.vtc
@@ -1,4 +1,5 @@
 varnishtest "tcp-check multiple ports"
+#EXCLUDE_TARGETS=freebsd,osx,generic
 #REGTEST_TYPE=slow
 # This test uses multiple tcp-check connect rules to perform health checking on
 # a target. It relies on port 1 being unbound on the local system.