From: Andres Freund <andres@anarazel.de>
Date: Mon, 13 Sep 2021 23:50:10 +0000 (-0700)
Subject: Fix potential for compiler warning in GlobalVisTestFor().
X-Git-Tag: REL_14_RC1~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d0bbee5e3ee2eabe3a1f6081cbc4226520764c0;p=thirdparty%2Fpostgresql.git

Fix potential for compiler warning in GlobalVisTestFor().

In d9d8aa9bb9a I added a defensive NULL assignment to protect against a
not-too-smart compiler warning about unitialized variable use after the
switch. Unfortunately I only did so on master and forgot to adjust that for
14.

Stephen noticed that there actually is a compiler warning :(.

Reported-By: Stephen Frost <sfrost@snowman.net>
Discussion: https://postgr.es/m/20210827224639.GX17906@tamriel.snowman.net
---

diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index aa3e1419a9e..739b4cd51d0 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -4027,7 +4027,7 @@ DisplayXidCache(void)
 GlobalVisState *
 GlobalVisTestFor(Relation rel)
 {
-	GlobalVisState *state;
+	GlobalVisState *state = NULL;
 
 	/* XXX: we should assert that a snapshot is pushed or registered */
 	Assert(RecentXmin);