From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Mon, 15 May 2023 16:03:35 +0000 (+0200)
Subject: BUG/MINOR: server: memory leak in _srv_update_status_op() on server DOWN
X-Git-Tag: v2.8-dev12~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d2f1acee61ee34aaf2583c40b1349d3f7b88a13;p=thirdparty%2Fhaproxy.git

BUG/MINOR: server: memory leak in _srv_update_status_op() on server DOWN

When server is transitionning from UP to DOWN, a log message is generated.
e.g.: "Server backend_name/server_name is DOWN")

However since f71e064 ("MEDIUM: server: split srv_update_status() in two
functions"), the allocated buffer tmptrash which is used to prepare the
log message is not freed after it has been used, resulting in a small
memory leak each time a server goes DOWN because of an operational
change.

This is a 2.8 specific bug, no backport needed unless the above commit
gets backported.
---

diff --git a/src/server.c b/src/server.c
index 956b78b3a8..a6e6b39d69 100644
--- a/src/server.c
+++ b/src/server.c
@@ -5387,6 +5387,7 @@ static int _srv_update_status_op(struct server *s, enum srv_op_st_chg_cause caus
 				 tmptrash->area);
 			send_email_alert(s, log_level, "%s",
 					 tmptrash->area);
+			free_trash_chunk(tmptrash);
 		}
 	}
 	else if ((s->cur_state != SRV_ST_STOPPING) && (s->next_state == SRV_ST_STOPPING)) {