From: Jack Xu Date: Fri, 14 Mar 2025 12:57:53 +0000 (+0000) Subject: crypto: qat - remove redundant FW image size check X-Git-Tag: v6.15-rc1~118^2~41 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d5cb730b59ba23d6472b8b1eacd351e7bc48c2b;p=thirdparty%2Fkernel%2Flinux.git crypto: qat - remove redundant FW image size check The FW image size check is already performed in the function qat_uclo_check_image() before calling `qat_uclo_map_auth_fw()`. Therefore, the additional check in `qat_uclo_map_auth_fw()` is redundant and can be safely removed. Signed-off-by: Jack Xu Reviewed-by: Ahsan Atta Reviewed-by: Giovanni Cabiddu Reviewed-by: Andy Shevchenko Signed-off-by: Giovanni Cabiddu Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/intel/qat/qat_common/qat_uclo.c b/drivers/crypto/intel/qat/qat_common/qat_uclo.c index 5ace036addeca..61be6df506847 100644 --- a/drivers/crypto/intel/qat/qat_common/qat_uclo.c +++ b/drivers/crypto/intel/qat/qat_common/qat_uclo.c @@ -1418,10 +1418,6 @@ static int qat_uclo_map_auth_fw(struct icp_qat_fw_loader_handle *handle, struct icp_qat_simg_ae_mode *simg_ae_mode; struct icp_firml_dram_desc img_desc; - if (size > (ICP_QAT_AE_IMG_OFFSET(handle) + ICP_QAT_CSS_RSA4K_MAX_IMAGE_LEN)) { - pr_err("QAT: error, input image size overflow %d\n", size); - return -EINVAL; - } length = (css_hdr->fw_type == CSS_AE_FIRMWARE) ? ICP_QAT_CSS_AE_SIMG_LEN(handle) + simg_offset : size + ICP_QAT_CSS_FWSK_PAD_LEN(handle) + simg_offset;