From: Alan Modra <amodra@gmail.com>
Date: Tue, 7 Mar 2017 00:34:19 +0000 (+1030)
Subject: PowerPC64 abort due to dynamic relocs on hidden undefweak
X-Git-Tag: users/ARM/embedded-binutils-2_28-branch-2017q2~146
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d69827324f704b75ac7e5c2b39219cdd15e790b;p=thirdparty%2Fbinutils-gdb.git

PowerPC64 abort due to dynamic relocs on hidden undefweak

ppc64_elf_relocate_section lacked a check which meant that it emitted
dynamic relocs against a hidden undefweak symbol for which no dynamic
relocs had been allocated.

	PR 21224
	PR 20519
	* elf64-ppc.c (ppc64_elf_relocate_section): Add missing
	dyn_relocs check.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 459c4050c29..17e7e3b9bf8 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2017-03-07  Alan Modra  <amodra@gmail.com>
+
+	PR 21224
+	PR 20519
+	* elf64-ppc.c (ppc64_elf_relocate_section): Add missing
+	dyn_relocs check.
+
 2017-03-07  Alan Modra  <amodra@gmail.com>
 
 	Apply from master
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index e7d47922454..3381647c467 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -14798,8 +14798,10 @@ ppc64_elf_relocate_section (bfd *output_bfd,
 	    break;
 
 	  if (bfd_link_pic (info)
-	      ? ((h != NULL && pc_dynrelocs (h))
-		 || must_be_dyn_reloc (info, r_type))
+	      ? ((h == NULL
+		  || h->dyn_relocs != NULL)
+		 && ((h != NULL && pc_dynrelocs (h))
+		     || must_be_dyn_reloc (info, r_type)))
 	      : (h != NULL
 		 ? h->dyn_relocs != NULL
 		 : ELF_ST_TYPE (sym->st_info) == STT_GNU_IFUNC))