From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 24 May 2024 14:30:59 +0000 (+0200)
Subject: BUG/MINOR: server: Don't reset resolver options on a new default-server line
X-Git-Tag: v3.0-dev13~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d7c1bc6ab694b0d7bcb66d6ff7158d12998de76;p=thirdparty%2Fhaproxy.git

BUG/MINOR: server: Don't reset resolver options on a new default-server line

When a new "default-server" line is parsed, some resolver options are reset.
Thus previously defined default options cannot be inherited. There is no
reason to do so. First because other server options are inherited. And then
because not all resolver options are reset. It is not consistent.

This patch should fix issue #2559. It should be backported to all stable
versions.
---

diff --git a/src/server.c b/src/server.c
index a12f7fe62a..caf2f40bb5 100644
--- a/src/server.c
+++ b/src/server.c
@@ -3459,8 +3459,6 @@ static int _srv_parse_init(struct server **srv, char **args, int *cur_arg,
 	else {
 		*srv = newsrv = &curproxy->defsrv;
 		*cur_arg = 1;
-		newsrv->resolv_opts.family_prio = AF_INET6;
-		newsrv->resolv_opts.accept_duplicate_ip = 0;
 	}
 
 	free(fqdn);