From: Jason Wang <jasowang@redhat.com>
Date: Tue, 19 Jul 2016 03:02:59 +0000 (+0800)
Subject: macvtap: correctly free skb during socket destruction
X-Git-Tag: v4.8-rc1~140^2~76
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0d7eacbe637952fc737a968bc16db1f2ccbbe71c;p=thirdparty%2Fkernel%2Flinux.git

macvtap: correctly free skb during socket destruction

We should use kfree_skb() instead of kfree() to free an skb.

Fixes: 362899b8725b ("macvtap: switch to use skb array")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9204d19fb30c2..a38c0dac514b8 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -536,7 +536,7 @@ static void macvtap_sock_destruct(struct sock *sk)
 	struct sk_buff *skb;
 
 	while ((skb = skb_array_consume(&q->skb_array)) != NULL)
-		kfree(skb);
+		kfree_skb(skb);
 }
 
 static int macvtap_open(struct inode *inode, struct file *file)