From: Alex <bigalex934@gmail.com>
Date: Sat, 16 Dec 2023 16:49:07 +0000 (+0000)
Subject: Polished TunnelStateData::usePinned() (#1619)
X-Git-Tag: SQUID_7_0_1~253
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0dc19a63f829d8f82c34df18fd9f8a4341d1aeb5;p=thirdparty%2Fsquid.git

Polished TunnelStateData::usePinned() (#1619)

... to avoid creating an impression of nil connManager dereference and
to reduce unwanted differences with FwdState::usePinned().
---

diff --git a/src/tunnel.cc b/src/tunnel.cc
index 72487ba55e..dca34bdc5d 100644
--- a/src/tunnel.cc
+++ b/src/tunnel.cc
@@ -1455,21 +1455,11 @@ TunnelStateData::usePinned()
 {
     Must(request);
     const auto connManager = request->pinnedConnection();
+    Comm::ConnectionPointer serverConn = nullptr;
+
     try {
-        const auto serverConn = ConnStateData::BorrowPinnedConnection(request.getRaw(), al);
+        serverConn = ConnStateData::BorrowPinnedConnection(request.getRaw(), al);
         debugs(26, 7, "pinned peer connection: " << serverConn);
-
-        updateAttempts(n_tries + 1);
-
-        // Set HttpRequest pinned related flags for consistency even if
-        // they are not really used by tunnel.cc code.
-        request->flags.pinned = true;
-        if (connManager->pinnedAuth())
-            request->flags.auth = true;
-
-        // the server may close the pinned connection before this request
-        const auto reused = true;
-        connectDone(serverConn, connManager->pinning.host, reused);
     } catch (ErrorState * const error) {
         syncHierNote(nullptr, connManager ? connManager->pinning.host : request->url.host());
         // XXX: Honor clientExpectsConnectResponse() before replying.
@@ -1478,6 +1468,19 @@ TunnelStateData::usePinned()
         return;
     }
 
+    updateAttempts(n_tries + 1);
+
+    // Set HttpRequest pinned related flags for consistency even if
+    // they are not really used by tunnel.cc code.
+    request->flags.pinned = true;
+
+    Assure(connManager);
+    if (connManager->pinnedAuth())
+        request->flags.auth = true;
+
+    // the server may close the pinned connection before this request
+    const auto reused = true;
+    connectDone(serverConn, connManager->pinning.host, reused);
 }
 
 CBDATA_CLASS_INIT(TunnelStateData);