From: Amit Kapila Date: Wed, 31 Jul 2024 03:23:55 +0000 (+0530) Subject: Fix random failure in 021_twophase. X-Git-Tag: REL_18_BETA1~2246 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0dcea330babd46402f6ca3ea3a552829c99bbe5e;p=thirdparty%2Fpostgresql.git Fix random failure in 021_twophase. After disabling the subscription, the failed test was changing the two_phase option for the subscription. We can't change the two_phase option for a subscription till the corresponding apply worker is active. The check to ensure that the replication apply worker has exited was incorrect. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm3YY+bzj+JWJbY+DsUgJ2mPk8OR1ttjVX2cywKr4BUgxw@mail.gmail.com --- diff --git a/src/test/subscription/t/021_twophase.pl b/src/test/subscription/t/021_twophase.pl index a47d3b7dd6e..5e50f1af338 100644 --- a/src/test/subscription/t/021_twophase.pl +++ b/src/test/subscription/t/021_twophase.pl @@ -385,7 +385,7 @@ is($result, qq(t), 'two-phase is enabled'); $node_subscriber->safe_psql('postgres', "ALTER SUBSCRIPTION tap_sub_copy DISABLE;"); $node_subscriber->poll_query_until('postgres', - "SELECT count(*) = 0 FROM pg_stat_activity WHERE backend_type = 'logical replication worker'" + "SELECT count(*) = 0 FROM pg_stat_activity WHERE backend_type = 'logical replication apply worker'" ); $node_subscriber->safe_psql( 'postgres', " @@ -434,7 +434,7 @@ is($result, qq(0), 'should be no prepared transactions on subscriber'); $node_subscriber->safe_psql('postgres', "ALTER SUBSCRIPTION tap_sub_copy DISABLE;"); $node_subscriber->poll_query_until('postgres', - "SELECT count(*) = 0 FROM pg_stat_activity WHERE backend_type = 'logical replication worker'" + "SELECT count(*) = 0 FROM pg_stat_activity WHERE backend_type = 'logical replication apply worker'" ); $node_subscriber->safe_psql( 'postgres', "