From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Mon, 26 Apr 2021 00:03:33 +0000 (+0900)
Subject: network: update comment and log message
X-Git-Tag: v249-rc1~344
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e27527170aa0179f2a4b3b55b78ddc049f815b9;p=thirdparty%2Fsystemd.git

network: update comment and log message

After 4b30f2e135ee84041bb597edca7225858f4ef4fb, reading stable_secret
sysctl property fails with -ENOMEM, instead of -EIO.
This is due to read_full_virtual_file() uses read() as the backend while
read_one_line_file() uses fgetc(). And each functions return different
error on fails.

Anyway, the failure is harmless here. So, the log message and comment is
updated.

Closes one of the issues in #19410.
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index a46aa5b9c33..63f31b72010 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -1327,8 +1327,9 @@ static int link_configure_addrgen_mode(Link *link) {
                 r = sysctl_read_ip_property(AF_INET6, link->ifname, "stable_secret", NULL);
                 if (r < 0) {
                         /* The file may not exist. And even if it exists, when stable_secret is unset,
-                         * reading the file fails with EIO. */
-                        log_link_debug_errno(link, r, "Failed to read sysctl property stable_secret: %m");
+                         * reading the file fails with ENOMEM when read_full_virtual_file(), which uses
+                         * read() as the backend, and EIO when read_one_line_file() which uses fgetc(). */
+                        log_link_debug_errno(link, r, "Failed to read sysctl property stable_secret, ignoring: %m");
 
                         ipv6ll_mode = IN6_ADDR_GEN_MODE_EUI64;
                 } else