From: Dave Chinner Date: Fri, 7 Jun 2013 00:25:49 +0000 (+1000) Subject: xfsprogs: disable xfs_check for CRC enabled filesystems X-Git-Tag: v3.2.0-alpha1~106 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e3105adf9aee65199a9fed8ffcc74f4a19adcb4;p=thirdparty%2Fxfsprogs-dev.git xfsprogs: disable xfs_check for CRC enabled filesystems Until xfs_db has full metadata CRC support, xfs_check will not be able to fully verify filesystems in this format. Don't even bother trying right now, and to make it simple to test full xfsprogs installs with xfstests, just silently succeed. Signed-off-by: Dave Chinner Reviewed-by: Ben Myers Signed-off-by: Ben Myers --- diff --git a/db/check.c b/db/check.c index 5b7498fda..dadfa9727 100644 --- a/db/check.c +++ b/db/check.c @@ -788,6 +788,20 @@ blockget_f( dbprintf(_("already have block usage information\n")); return 0; } + + /* + * XXX: check does not support CRC enabled filesystems. Return + * immediately, silently, with success but without doing anything here + * initially so that xfstests can run without modification on metadata + * enabled filesystems. + * + * XXX: ultimately we need to dump an error message here that xfstests + * filters out, or we need to actually do the work to make check support + * crc enabled filesystems. + */ + if (xfs_sb_version_hascrc(&mp->m_sb)) + return 0; + if (!init(argc, argv)) { if (serious_error) exitcode = 3;