From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date: Thu, 18 Apr 2019 07:47:41 +0000 (+0200)
Subject: HID: input: fix assignment of .value
X-Git-Tag: v5.1.12~112
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e3b0666fbe80dd239ea3d07c71d3d787eaf80b4;p=thirdparty%2Fkernel%2Fstable.git

HID: input: fix assignment of .value

commit 39b3c3a5fbc5d744114e497d35bf0c12f798c134 upstream.

The value field is actually an array of .maxfield. We should assign the
correct number to the correct usage.

Not that we never encounter a device that requires this ATM, but better
have the proper code path.

Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for
       high-resolution scrolling")
Cc: stable@vger.kernel.org  # v5.0+
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 11ff4d08b3d6b..46c6efea1404e 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1595,7 +1595,7 @@ static bool __hidinput_change_resolution_multipliers(struct hid_device *hid,
 			if (usage->hid != HID_GD_RESOLUTION_MULTIPLIER)
 				continue;
 
-			*report->field[i]->value = value;
+			report->field[i]->value[j] = value;
 			update_needed = true;
 		}
 	}