From: Henrik Nordstrom <henrik@henriknordstrom.net>
Date: Mon, 5 Mar 2012 11:36:38 +0000 (+0100)
Subject: Document master/slave DNS query relation and search path processing
X-Git-Tag: BumpSslServerFirst.take06~2^2~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e6432d004bcaab7518abbcaab2054588cdcb4cf;p=thirdparty%2Fsquid.git

Document master/slave DNS query relation and search path processing
---

diff --git a/src/dns_internal.cc b/src/dns_internal.cc
index 8c8284d568..590e00f89f 100644
--- a/src/dns_internal.cc
+++ b/src/dns_internal.cc
@@ -143,8 +143,8 @@ struct _idns_query {
     int attempt;
     int rcode;
     idns_query *queue;
-    idns_query *slave;  // AAAA
-    idns_query *master; // A
+    idns_query *slave;  // single linked list
+    idns_query *master; // single pointer to a shared master
     unsigned short domain;
     unsigned short do_searchpath;
     rfc1035_message *message;
@@ -1180,7 +1180,9 @@ idnsGrokReply(const char *buf, size_t sz, int from_ns)
             return;
         }
 
-        // Do searchpath processing on the master A query only, ignoring any AAAA query
+        // Do searchpath processing on the master A query only to keep
+        // things simple. NXDOMAIN is authorative for the label, not
+        // the record type.
         if (q->rcode == 3 && !q->master && q->do_searchpath && q->attempt < MAX_ATTEMPT) {
             assert(NULL == message->answer);
             strcpy(q->name, q->orig);