From: Willy Tarreau <w@1wt.eu>
Date: Fri, 20 Aug 2021 08:23:12 +0000 (+0200)
Subject: BUG/MINOR: http_client: make sure to preset the proxy's default settings
X-Git-Tag: v2.5-dev5~55
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e72e40f7e25e5c3a6e9e64d5715776cfdec7fd3;p=thirdparty%2Fhaproxy.git

BUG/MINOR: http_client: make sure to preset the proxy's default settings

Proxies must call proxy_preset_defaults() to initialize their settings
that are usually learned from defaults sections (e.g. connection retries,
pool purge delay etc). At the moment there was likely no impact, but not
doing so could cause trouble soon when using the client more extensively
or when new defaults are introduced and failed to be initialized.

No backport is needed.
---

diff --git a/src/http_client.c b/src/http_client.c
index b949e09d2b..6142c4857e 100644
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -657,6 +657,8 @@ static int httpclient_init()
 		goto err;
 	}
 
+	proxy_preset_defaults(httpclient_proxy);
+
 	httpclient_proxy->options2 |= PR_O2_INDEPSTR;
 	httpclient_proxy->mode = PR_MODE_HTTP;
 	httpclient_proxy->maxconn = 0;