From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Sun, 11 Jul 2021 17:54:16 +0000 (+0200)
Subject: firewall.cgi: Remove faulty assignments for selected hash.
X-Git-Tag: v2.27-core160~117
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0e9b16472230a7f1022cebc445615905574e3e23;p=ipfire-2.x.git

firewall.cgi: Remove faulty assignments for selected hash.

The removed assignments are wrong because both are trying to assign
something different to the same key and will overwrite each other.

Secondary the assignment to the hash is not needed at this place, so it
safely can be removed.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
---

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 70dee8d3cc..d3cddfa239 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -1022,8 +1022,6 @@ sub gen_dd_block
 	$checked{'TIME_SUN'}{$fwdfwsettings{'TIME_SUN'}} 		= 'CHECKED';
 	$selected{'TIME_FROM'}{$fwdfwsettings{'TIME_FROM'}}		= 'selected';
 	$selected{'TIME_TO'}{$fwdfwsettings{'TIME_TO'}}			= 'selected';
-	$selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp1'}}} ='selected';
-	$selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp2'}}} ='selected';
 print<<END;
 		<table width='100%' border='0'>
 		<tr><td width='50%' valign='top'>