From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 15 Oct 2008 07:43:48 +0000 (+0000)
Subject: - John Wilkinson filed bug #2155496
X-Git-Tag: curl-7_19_1~147
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ecdcc253b87b5575c2cd96ac2f92a170bb3c906;p=thirdparty%2Fcurl.git

- John Wilkinson filed bug #2155496
  (http://curl.haxx.se/bug/view.cgi?id=2155496) pointing out an error case
  without a proper human-readable error message. When a read callback returns
  a too large value (like when trying to return a negative number) it would
  trigger and the generic error message then makes the proplem slightly
  different to track down. I've added an error message for this now.
---

diff --git a/CHANGES b/CHANGES
index e755376891..22eee97219 100644
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,14 @@
 
                                   Changelog
 
+Daniel Stenberg (15 Oct 2008)
+- John Wilkinson filed bug #2155496
+  (http://curl.haxx.se/bug/view.cgi?id=2155496) pointing out an error case
+  without a proper human-readable error message. When a read callback returns
+  a too large value (like when trying to return a negative number) it would
+  trigger and the generic error message then makes the proplem slightly
+  different to track down. I've added an error message for this now.
+
 Daniel Fandrich (9 Oct 2008)
 - Fixed the --interface option to work with IPv6 connections on glibc
   systems supporting getifaddrs(). Also fixed a problem where an IPv6
diff --git a/lib/transfer.c b/lib/transfer.c
index bd6629916b..f15d9a0f25 100644
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -152,6 +152,7 @@ CURLcode Curl_fillreadbuffer(struct connectdata *conn, int bytes, int *nreadp)
   else if((size_t)nread > buffersize) {
     /* the read function returned a too large value */
     *nreadp = 0;
+    failf(data, "read function returned funny value");
     return CURLE_READ_ERROR;
   }