From: Junio C Hamano Date: Mon, 5 Aug 2013 16:47:11 +0000 (-0700) Subject: t3900: test rejecting log message with NULs correctly X-Git-Tag: v1.8.4-rc2~5^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ed45a1cd6571ed89a09791730a9089e932b7c1f;p=thirdparty%2Fgit.git t3900: test rejecting log message with NULs correctly It is not like that our longer term desire is to someday start accept log messages with NULs in them, so it is wrong to mark a test that demonstrates "git commit" that correctly fails given such an input as "expect-failure". "git commit" should fail today, and it should fail the same way in the future given a message with NUL in it. Signed-off-by: Junio C Hamano --- diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh index d48a7c002d..a9e56629d8 100755 --- a/t/t3900-i18n-commit.sh +++ b/t/t3900-i18n-commit.sh @@ -34,9 +34,9 @@ test_expect_success 'no encoding header for base case' ' test z = "z$E" ' -test_expect_failure 'UTF-16 refused because of NULs' ' +test_expect_success 'UTF-16 refused because of NULs' ' echo UTF-16 >F && - git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt + test_must_fail git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt '