From: Frank Becker <Frank@Frank-Becker.de>
Date: Wed, 24 Aug 2016 14:25:43 +0000 (-0400)
Subject: Bug 1296831 - allow answers file to override new install defaults
X-Git-Tag: release-5.1.2~86
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0ee74224619e84abe3c4004fc8f756442574c3d9;p=thirdparty%2Fbugzilla.git

Bug 1296831 - allow answers file to override new install defaults
---

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 79b468f0c8..49918d5c10 100644
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -36,6 +36,12 @@ use File::Basename;
   );
 Exporter::export_ok_tags('admin');
 
+# new installs get these set of defaults (unless overriden by the answers file)
+my %NEW_INSTALL_DEFAULT = (
+    or_groups          => 1,
+    use_email_as_login => 0,
+);
+
 # INITIALISATION CODE
 # Perl throws a warning if we use bz_locations() directly after do.
 our %params;
@@ -238,17 +244,15 @@ sub update_params {
             elsif (exists $answer->{$name}) {
                 $param->{$name} = $answer->{$name};
             }
+            elsif ($new_install and exists $NEW_INSTALL_DEFAULT{$name}) {
+                $param->{$name} = $NEW_INSTALL_DEFAULT{$name};
+            }
             else {
                 $param->{$name} = $item->{'default'};
             }
         }
     }
 
-    if ($new_install) {
-        $param->{'or_groups'} = 1;
-        $param->{'use_email_as_login'} = 0;
-    }
-
     # --- REMOVE OLD PARAMS ---
 
     my %oldparams;