From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sun, 11 Jul 2021 19:24:14 +0000 (+0000)
Subject: Fix ACL-related reconfiguration memory leak (#859)
X-Git-Tag: SQUID_6_0_1~313
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0f04d0e8145945cee103431e7d1d1ffc1b0855ab;p=thirdparty%2Fsquid.git

Fix ACL-related reconfiguration memory leak (#859)

Leaking since commit 4eac340 that migrated from statically-allocated
ACLStrategy<...>::Instance_ objects to dynamically allocated ones.

Most ACLStrategy objects have no data members, probably leaking just one
virtual table pointer (per named ACL), but strategies that support ACL
(data) --options, like ACLDestinationDomainStrategy and
ACLServerNameStrategy, leak memory used for options storage.
---

diff --git a/src/acl/Strategised.h b/src/acl/Strategised.h
index 0d3b4b8d19..b933257cf6 100644
--- a/src/acl/Strategised.h
+++ b/src/acl/Strategised.h
@@ -64,6 +64,7 @@ template <class MatchType>
 ACLStrategised<MatchType>::~ACLStrategised()
 {
     delete data;
+    delete matcher;
 }
 
 template <class MatchType>