From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 31 Jul 2025 13:31:59 +0000 (+0200)
Subject: virCHDomainRefreshThreadInfo: Remove illusion that caller cares about return value
X-Git-Tag: v11.7.0-rc1~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0f0d561da2fbf5d95c355097b3d0c52d843d1f1e;p=thirdparty%2Flibvirt.git

virCHDomainRefreshThreadInfo: Remove illusion that caller cares about return value

The caller doesn't check the return value. Remove it to avoid confusing
readers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
index 85bd99e1e9..6ace9eafbf 100644
--- a/src/ch/ch_domain.c
+++ b/src/ch/ch_domain.c
@@ -254,7 +254,7 @@ chValidateDomainDeviceDef(const virDomainDeviceDef *dev,
     return 0;
 }
 
-int
+void
 virCHDomainRefreshThreadInfo(virDomainObj *vm)
 {
     unsigned int maxvcpus = virDomainDefGetVcpusMax(vm->def);
@@ -291,8 +291,6 @@ virCHDomainRefreshThreadInfo(virDomainObj *vm)
     if (ncpus != maxvcpus)
         VIR_WARN("Mismatch in the number of cpus, expected: %u, actual: %zu",
                  maxvcpus, ncpus);
-
-    return 0;
 }
 
 virDomainDefParserConfig virCHDriverDomainDefParserConfig = {
diff --git a/src/ch/ch_domain.h b/src/ch/ch_domain.h
index 69a657f6af..4532fe9ce0 100644
--- a/src/ch/ch_domain.h
+++ b/src/ch/ch_domain.h
@@ -62,7 +62,7 @@ void
 virCHDomainRemoveInactive(virCHDriver *driver,
                           virDomainObj *vm);
 
-int
+void
 virCHDomainRefreshThreadInfo(virDomainObj *vm);
 
 pid_t