From: Marek Vasut Date: Mon, 15 Sep 2025 00:49:05 +0000 (+0200) Subject: ARM: stm32: Perform node compatible check for KS8851 early X-Git-Tag: v2025.10-rc5~7^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0f4bfee3cfe7e0786b8bf748c523c8e78eda8423;p=thirdparty%2Fu-boot.git ARM: stm32: Perform node compatible check for KS8851 early Check the compatible string of ethernet1 node for KS8851 very early on, before calling uclass_get_device_by_of_path() which might initialize the device and possibly attempt to configure MAC address into device which is not KS8851. Doing the compatibility check early prevent this. Signed-off-by: Marek Vasut Reviewed-by: Patrice Chotard --- diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c index f7347bbb826..bd9326d6b1b 100644 --- a/board/dhelectronics/dh_stm32mp1/board.c +++ b/board/dhelectronics/dh_stm32mp1/board.c @@ -85,6 +85,9 @@ static bool dh_stm32_mac_is_in_ks8851(void) if (!ofnode_valid(node)) return false; + if (!ofnode_device_is_compatible(node, "micrel,ks8851-mll")) + return false; + ret = ofnode_get_path(node, path, sizeof(path)); if (ret) return false; @@ -93,9 +96,6 @@ static bool dh_stm32_mac_is_in_ks8851(void) if (ret) return false; - if (!ofnode_device_is_compatible(node, "micrel,ks8851-mll")) - return false; - /* * KS8851 with EEPROM may use custom MAC from EEPROM, read * out the KS8851 CCR register to determine whether EEPROM