From: Selva Nair <selva.nair@gmail.com>
Date: Thu, 20 Jan 2022 16:26:45 +0000 (-0500)
Subject: Fix a potential memory leak in tls_ctx_use_management_external_key
X-Git-Tag: v2.6_beta1~302
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0f7cd474118deeced48168ed9cec0806e7f4cc15;p=thirdparty%2Fopenvpn.git

Fix a potential memory leak in tls_ctx_use_management_external_key

Reported-By: Gert Doering <gert@greenie.muc.de>

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Antonio Quartulli <a@unstable.cc>
Message-Id: <20220120162645.13881-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23610.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c
index c4eaf232e..b85951748 100644
--- a/src/openvpn/ssl_openssl.c
+++ b/src/openvpn/ssl_openssl.c
@@ -1493,6 +1493,7 @@ tls_ctx_use_management_external_key(struct tls_root_ctx *ctx)
     if (!privkey
         || !SSL_CTX_use_PrivateKey(ctx->ctx, privkey))
     {
+        EVP_PKEY_free(privkey);
         goto cleanup;
     }
     EVP_PKEY_free(privkey);