From: Wouter Wijngaards <wouter@nlnetlabs.nl>
Date: Thu, 25 Oct 2018 07:49:49 +0000 (+0000)
Subject: Move rcode code back.
X-Git-Tag: release-1.8.2rc1~44
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0f83653e768b8a61a9761b14878f51e933a47b8f;p=thirdparty%2Funbound.git

Move rcode code back.


git-svn-id: file:///svn/unbound/trunk@4948 be551aaa-1e26-0410-a405-d3ace91eadb9
---

diff --git a/dns64/dns64.c b/dns64/dns64.c
index 51e7437e6..7db8f4cef 100644
--- a/dns64/dns64.c
+++ b/dns64/dns64.c
@@ -896,10 +896,6 @@ dns64_inform_super(struct module_qstate* qstate, int id,
 	 */
 	super->minfo[id] = (void*)DNS64_SUBQUERY_FINISHED;
 
-	/* Use return code from A query in response to client. */
-	if (super->return_rcode != LDNS_RCODE_NOERROR)
-		super->return_rcode = qstate->return_rcode;
-
 	/* If there is no successful answer, we're done. */
 	if (qstate->return_rcode != LDNS_RCODE_NOERROR
 	    || !qstate->return_msg
@@ -907,6 +903,10 @@ dns64_inform_super(struct module_qstate* qstate, int id,
 		return;
 	}
 
+	/* Use return code from A query in response to client. */
+	if (super->return_rcode != LDNS_RCODE_NOERROR)
+		super->return_rcode = qstate->return_rcode;
+
 	/* Generate a response suitable for the original query. */
 	if (qstate->qinfo.qtype == LDNS_RR_TYPE_A) {
 		dns64_adjust_a(id, super, qstate);