From: Johannes Thumshirn Date: Wed, 31 May 2023 11:50:33 +0000 (-0700) Subject: zonefs: use __bio_add_page for adding single page to bio X-Git-Tag: v6.5-rc1~114^2~157 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0fa5b08cf6e17b0a64ffcc5894d8efe186691ab8;p=thirdparty%2Fkernel%2Flinux.git zonefs: use __bio_add_page for adding single page to bio The zonefs superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Acked-by: Damien Le Moal Reviewed-by: Christoph Hellwig Signed-off-by: Johannes Thumshirn Link: https://lore.kernel.org/r/04c9978ccaa0fc9871cd4248356638d98daccf0c.1685532726.git.johannes.thumshirn@wdc.com Signed-off-by: Jens Axboe --- diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 23b8b299c64e1..9350221abfc55 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ); bio.bi_iter.bi_sector = 0; - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); ret = submit_bio_wait(&bio); if (ret)