From: Nikita Shubin <n.shubin@yadro.com>
Date: Tue, 14 Dec 2021 09:26:59 +0000 (+0300)
Subject: target/riscv/pmp: fix no pmp illegal intrs
X-Git-Tag: v7.0.0-rc0~101^2~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0fbb5d2d3c9ded9fbd3f6f993974cc5e88e28912;p=thirdparty%2Fqemu.git

target/riscv/pmp: fix no pmp illegal intrs

As per the privilege specification, any access from S/U mode should fail
if no pmp region is configured and pmp is present, othwerwise access
should succeed.

Fixes: d102f19a208 (target/riscv/pmp: Raise exception if no PMP entry is configured)
Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20211214092659.15709-1-nikita.shubin@maquefel.me
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---

diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c
index ee7c24efe77..58d992e98a2 100644
--- a/target/riscv/op_helper.c
+++ b/target/riscv/op_helper.c
@@ -146,7 +146,8 @@ target_ulong helper_mret(CPURISCVState *env, target_ulong cpu_pc_deb)
     uint64_t mstatus = env->mstatus;
     target_ulong prev_priv = get_field(mstatus, MSTATUS_MPP);
 
-    if (!pmp_get_num_rules(env) && (prev_priv != PRV_M)) {
+    if (riscv_feature(env, RISCV_FEATURE_PMP) &&
+        !pmp_get_num_rules(env) && (prev_priv != PRV_M)) {
         riscv_raise_exception(env, RISCV_EXCP_ILLEGAL_INST, GETPC());
     }