From: Nathan Bossart <nathan@postgresql.org>
Date: Mon, 9 Dec 2024 22:26:23 +0000 (-0600)
Subject: Fix unused-but-set-variable compiler warning in reorderbuffer.c.
X-Git-Tag: REL_13_19~64
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=0fbcb9da181452e236b5aca6bf00c20ebcd7ec6b;p=thirdparty%2Fpostgresql.git

Fix unused-but-set-variable compiler warning in reorderbuffer.c.

On v13, this variable is only used for an assertion, so adding
PG_USED_FOR_ASSERTS_ONLY is sufficient to suppress this warning on
builds with assertions disabled.  Older versions are unsupported,
and newer versions use the variable for more than the assertion, so
this patch only needs to be applied to REL_13_STABLE.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/Z1dCFnzrP24O8WNR%40nathan
---

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index c7f8fa6216c..56c25e3a6da 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -2468,7 +2468,7 @@ ReorderBufferSerializeTXN(ReorderBuffer *rb, ReorderBufferTXN *txn)
 	dlist_mutable_iter change_i;
 	int			fd = -1;
 	XLogSegNo	curOpenSegNo = 0;
-	Size		spilled = 0;
+	Size		spilled PG_USED_FOR_ASSERTS_ONLY = 0;
 
 	elog(DEBUG2, "spill %u changes in XID %u to disk",
 		 (uint32) txn->nentries_mem, txn->xid);