From: Kirill Tkhai Date: Thu, 29 Mar 2018 16:20:44 +0000 (+0300) Subject: net: Don't take rtnl_lock() in wireless_nlevent_flush() X-Git-Tag: v4.17-rc1~148^2~66^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10256debb918aea083d0ddada64d29014c642a7b;p=thirdparty%2Fkernel%2Flinux.git net: Don't take rtnl_lock() in wireless_nlevent_flush() This function iterates over net_namespace_list and flushes the queue for every of them. What does this rtnl_lock() protects?! Since we may add skbs to net::wext_nlevents without rtnl_lock(), it does not protects us about queuers. It guarantees, two threads can't flush the queue in parallel, that can change the order, but since skb can be queued in any order, it doesn't matter, how many threads do this in parallel. In case of several threads, this will be even faster. So, we can remove rtnl_lock() here, as it was used for iteration over net_namespace_list only. Signed-off-by: Kirill Tkhai Signed-off-by: David S. Miller --- diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c index 544d7b62d7ca9..5e677dac2a0ce 100644 --- a/net/wireless/wext-core.c +++ b/net/wireless/wext-core.c @@ -347,8 +347,6 @@ void wireless_nlevent_flush(void) struct sk_buff *skb; struct net *net; - ASSERT_RTNL(); - down_read(&net_rwsem); for_each_net(net) { while ((skb = skb_dequeue(&net->wext_nlevents))) @@ -412,9 +410,7 @@ subsys_initcall(wireless_nlevent_init); /* Process events generated by the wireless layer or the driver. */ static void wireless_nlevent_process(struct work_struct *work) { - rtnl_lock(); wireless_nlevent_flush(); - rtnl_unlock(); } static DECLARE_WORK(wireless_nlevent_work, wireless_nlevent_process);