From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 20 May 2010 12:00:01 +0000 (+1200)
Subject: Remove useless address copy from idns
X-Git-Tag: take08~55^2~124^2~146
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=105f7a99f99c1341c96c8b195f4bb3732e14fa7b;p=thirdparty%2Fsquid.git

Remove useless address copy from idns
---

diff --git a/src/dns_internal.cc b/src/dns_internal.cc
index 73eaf56d13..8ac8cdd9d1 100644
--- a/src/dns_internal.cc
+++ b/src/dns_internal.cc
@@ -736,20 +736,17 @@ idnsInitVC(int ns)
     nsvc *vc = cbdataAlloc(nsvc);
     nameservers[ns].vc = vc;
     vc->ns = ns;
-
-    Ip::Address addr;
-
-    if (!Config.Addrs.udp_outgoing.IsNoAddr())
-        addr = Config.Addrs.udp_outgoing;
-    else
-        addr = Config.Addrs.udp_incoming;
-
     vc->queue = new MemBuf;
     vc->msg = new MemBuf;
     vc->busy = 1;
 
     Comm::Connection *conn = new Comm::Connection;
-    conn->local = addr;
+
+    if (!Config.Addrs.udp_outgoing.IsNoAddr())
+        conn->local = Config.Addrs.udp_outgoing;
+    else
+        conn->local = Config.Addrs.udp_incoming;
+
     conn->remote = nameservers[ns].S;
 
     AsyncCall::Pointer call = commCbCall(78,3, "idnsInitVCConnected", CommConnectCbPtrFun(idnsInitVCConnected, vc));