From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 29 Jul 2025 10:41:21 +0000 (+0200)
Subject: virDomainVcpuDefPostParse: Remove impossible check
X-Git-Tag: v11.7.0-rc1~39
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1067afb690dd5bc804408e2aec6be7a6e03cd037;p=thirdparty%2Flibvirt.git

virDomainVcpuDefPostParse: Remove impossible check

Many callers of 'virDomainDefGetVcpu' don't validate return value when
iterating CPUs up to def->maxvcpus/virDomainDefGetVcpusMax. Remove this
one.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c
index a07ec8d94e..38e731348d 100644
--- a/src/conf/domain_postparse.c
+++ b/src/conf/domain_postparse.c
@@ -1013,10 +1013,6 @@ virDomainVcpuDefPostParse(virDomainDef *def)
     for (i = 0; i < maxvcpus; i++) {
         vcpu = virDomainDefGetVcpu(def, i);
 
-        /* impossible but some compilers don't like it */
-        if (!vcpu)
-            continue;
-
         switch (vcpu->hotpluggable) {
         case VIR_TRISTATE_BOOL_ABSENT:
             if (vcpu->online)