From: Rafael J. Wysocki Date: Wed, 11 Oct 2023 15:45:42 +0000 (+0200) Subject: thermal: trip: Drop lockdep assertion from thermal_zone_trip_id() X-Git-Tag: v6.7-rc1~159^2~3^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=108ffd12be24ba1d74b3314df8db32a0a6d55ba5;p=thirdparty%2Fkernel%2Flinux.git thermal: trip: Drop lockdep assertion from thermal_zone_trip_id() The lockdep assertion in thermal_zone_trip_id() triggers when the trip point sysfs attribute of a thermal instance is read, because there is no thermal zone locking in that code path. This is not verly useful, though, because there is no mechanism by which the location of the trips[] table in a thermal zone or its size can change after binding cooling devices to the trips in that thermal zone and before those cooling devices are unbound from them. Thus it is not in fact necessary to hold the thermal zone lock when thermal_zone_trip_id() is called from trip_point_show() and so the lockdep asserion in the former is invalid. Accordingly, drop that lockdep assertion. Fixes: 2c7b4bfadef0 ("thermal: core: Store trip pointer in struct thermal_instance") Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/thermal/thermal_trip.c b/drivers/thermal/thermal_trip.c index 9f10e2ff92484..80f3cdb2f30ee 100644 --- a/drivers/thermal/thermal_trip.c +++ b/drivers/thermal/thermal_trip.c @@ -175,8 +175,6 @@ int thermal_zone_trip_id(struct thermal_zone_device *tz, { int i; - lockdep_assert_held(&tz->lock); - for (i = 0; i < tz->num_trips; i++) { if (&tz->trips[i] == trip) return i;