From: Oleg Nesterov Date: Tue, 7 Jan 2025 16:27:24 +0000 (+0100) Subject: poll_wait: kill the obsolete wait_address check X-Git-Tag: v6.13-rc7~23^2^2^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10b02a2cfec2f106db4897ad87732db56d71e6fd;p=thirdparty%2Flinux.git poll_wait: kill the obsolete wait_address check This check is historical and no longer needed, wait_address is never NULL. These days we rely on the poll_table->_qproc check. NULL if select/poll is not going to sleep, or it already has a data to report, or all waiters have already been registered after the 1st iteration. However, poll_table *p can be NULL, see p9_fd_poll() for example, so we can't remove the "p != NULL" check. Link: https://lore.kernel.org/all/20250106180325.GF7233@redhat.com/ Signed-off-by: Oleg Nesterov Link: https://lore.kernel.org/r/20250107162724.GA18926@redhat.com Signed-off-by: Christian Brauner --- diff --git a/include/linux/poll.h b/include/linux/poll.h index fc641b50f1298..57b6d1ccd8bf0 100644 --- a/include/linux/poll.h +++ b/include/linux/poll.h @@ -41,7 +41,7 @@ typedef struct poll_table_struct { static inline void poll_wait(struct file * filp, wait_queue_head_t * wait_address, poll_table *p) { - if (p && p->_qproc && wait_address) { + if (p && p->_qproc) { p->_qproc(filp, wait_address, p); /* * This memory barrier is paired in the wq_has_sleeper().