From: Christoph Hellwig <hch@lst.de>
Date: Sat, 13 Oct 2018 07:26:24 +0000 (+0200)
Subject: scsi: sun_esp: don't use GFP_ATOMIC for command block allocation
X-Git-Tag: v4.20-rc1~127^2~97
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10c0cd38ce4cd2015a683e296596738adab9221f;p=thirdparty%2Fkernel%2Flinux.git

scsi: sun_esp: don't use GFP_ATOMIC for command block allocation

esp_sbus_map_command_block is called straight from the probe routine
without any locks held, so we can safely use GFP_KERNEL here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c
index 747ee64a78e1c..c7b60ed61c38f 100644
--- a/drivers/scsi/sun_esp.c
+++ b/drivers/scsi/sun_esp.c
@@ -104,7 +104,7 @@ static int esp_sbus_map_command_block(struct esp *esp)
 
 	esp->command_block = dma_alloc_coherent(&op->dev, 16,
 						&esp->command_block_dma,
-						GFP_ATOMIC);
+						GFP_KERNEL);
 	if (!esp->command_block)
 		return -ENOMEM;
 	return 0;