From: Lai Jiangshan Date: Mon, 1 Jun 2020 08:44:40 +0000 (+0000) Subject: workqueue: use BUILD_BUG_ON() for compile time test instead of WARN_ON() X-Git-Tag: v5.8-rc1~117^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10cdb15759540f03d056e2f73fe26377ed7dcfda;p=thirdparty%2Fkernel%2Flinux.git workqueue: use BUILD_BUG_ON() for compile time test instead of WARN_ON() Any runtime WARN_ON() has to be fixed, and BUILD_BUG_ON() can help you nitice it earlier. Signed-off-by: Lai Jiangshan Signed-off-by: Tejun Heo --- diff --git a/kernel/workqueue.c b/kernel/workqueue.c index c667ca5aed61a..9fbe1e2375638 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5917,7 +5917,7 @@ void __init workqueue_init_early(void) int hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ; int i, cpu; - WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long)); + BUILD_BUG_ON(__alignof__(struct pool_workqueue) < __alignof__(long long)); BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL)); cpumask_copy(wq_unbound_cpumask, housekeeping_cpumask(hk_flags));