From: Pauli <pauli@openssl.org>
Date: Mon, 31 May 2021 04:28:15 +0000 (+1000)
Subject: asn.1: remove TODOs
X-Git-Tag: openssl-3.0.0-beta1~261
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10dbfcc91eb84b9818393e48745dcb53914c57d4;p=thirdparty%2Fopenssl.git

asn.1: remove TODOs

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)
---

diff --git a/crypto/asn1/bio_asn1.c b/crypto/asn1/bio_asn1.c
index 3742b0096fd..fa81b3a28ad 100644
--- a/crypto/asn1/bio_asn1.c
+++ b/crypto/asn1/bio_asn1.c
@@ -79,10 +79,8 @@ static int asn1_bio_setup_ex(BIO *b, BIO_ASN1_BUF_CTX *ctx,
 static const BIO_METHOD methods_asn1 = {
     BIO_TYPE_ASN1,
     "asn1",
-    /* TODO: Convert to new style write function */
     bwrite_conv,
     asn1_bio_write,
-    /* TODO: Convert to new style read function */
     bread_conv,
     asn1_bio_read,
     asn1_bio_puts,
diff --git a/include/crypto/asn1.h b/include/crypto/asn1.h
index 5a187e41a7f..829c5980d23 100644
--- a/include/crypto/asn1.h
+++ b/include/crypto/asn1.h
@@ -74,10 +74,6 @@ struct evp_pkey_asn1_method_st {
     int (*get_priv_key) (const EVP_PKEY *pk, unsigned char *priv, size_t *len);
     int (*get_pub_key) (const EVP_PKEY *pk, unsigned char *pub, size_t *len);
 
-    /*
-     * TODO: Make sure these functions are defined for key types that are
-     * implemented in providers.
-     */
     /* Exports and imports to / from providers */
     size_t (*dirty_cnt) (const EVP_PKEY *pk);
     int (*export_to) (const EVP_PKEY *pk, void *to_keydata,