From: Yonggang Luo <luoyonggang@gmail.com>
Date: Thu, 20 Oct 2022 18:25:43 +0000 (+0800)
Subject: libelf/libdwfl: Remove LIB_SYSTEM_H define in lib{elf,dwfl}_crc32.c
X-Git-Tag: elfutils-0.188~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=10f01dad96325706c746000e467e2a33197e6ea2;p=thirdparty%2Felfutils.git

libelf/libdwfl: Remove LIB_SYSTEM_H define in lib{elf,dwfl}_crc32.c

rationale: https://sourceware.org/bugzilla/show_bug.cgi?id=21001

If we don't remove this macro, when try #include <system.h> in
libdw/memory-access.h wont' take effect because
"#define LIB_SYSTEM_H	1"
The compile error:
./../libdw/memory-access.h:390:12: error: implicit declaration of
function ‘bswap_32’ [-Werror=implicit-function-declaration]

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index faa97fca6..5254ac455 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2022-10-21  Yonggang Luo  <luoyonggang@gmail.com>
+
+	* libdwfl_crc32.c: Remove LIB_SYSTEM_H define.
+
 2022-09-20  Yonggang Luo  <luoyonggang@gmail.com>
 
 	* dwfl_segment_report_module.c: Use BYTE_ORDER, LITTLE_ENDIAN and
diff --git a/libdwfl/libdwfl_crc32.c b/libdwfl/libdwfl_crc32.c
index b89d0d36b..5bc7a4add 100644
--- a/libdwfl/libdwfl_crc32.c
+++ b/libdwfl/libdwfl_crc32.c
@@ -30,6 +30,5 @@
 #endif
 
 #define crc32 attribute_hidden __libdwfl_crc32
-#define LIB_SYSTEM_H	1
 #include <libdwflP.h>
 #include "../lib/crc32.c"
diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index 86b12e815..aefb31b38 100644
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,3 +1,7 @@
+2022-10-21  Yonggang Luo  <luoyonggang@gmail.com>
+
+	* libelf_crc32.c: Remove LIB_SYSTEM_H define.
+
 2022-09-20  Yonggang Luo  <luoyonggang@gmail.com>
 
 	* elf32_checksum.c: Use BYTE_ORDER, LITTLE_ENDIAN and BIG_ENDIAN.
diff --git a/libelf/libelf_crc32.c b/libelf/libelf_crc32.c
index 1426faf1a..f1cf48685 100644
--- a/libelf/libelf_crc32.c
+++ b/libelf/libelf_crc32.c
@@ -30,6 +30,5 @@
 #endif
 
 #define crc32 attribute_hidden __libelf_crc32
-#define LIB_SYSTEM_H	1
 #include <libelf.h>
 #include "../lib/crc32.c"