From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: Mon, 4 Jun 2018 15:37:21 +0000 (-0300)
Subject: linux-user: Export use is_error(), use it to avoid warnings
X-Git-Tag: v3.0.0-rc0~91^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1129dd712157b42397275681e6397bf2d6bdfa0e;p=thirdparty%2Fqemu.git

linux-user: Export use is_error(), use it to avoid warnings

This fixes:

  linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion
      if (res > (unsigned long)-4096)
          ^~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20180604153722.24956-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---

diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 6fa1e968db3..793cd4df047 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -618,6 +618,11 @@ static inline void *lock_user_string(abi_ulong guest_addr)
 
 #include <pthread.h>
 
+static inline int is_error(abi_long ret)
+{
+    return (abi_ulong)ret >= (abi_ulong)(-4096);
+}
+
 /* Include target-specific struct and function definitions;
  * they may need access to the target-independent structures
  * above, so include them last.
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 7b9ac3b4086..2117fb13b4a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -906,11 +906,6 @@ static inline abi_long get_errno(abi_long ret)
         return ret;
 }
 
-static inline int is_error(abi_long ret)
-{
-    return (abi_ulong)ret >= (abi_ulong)(-4096);
-}
-
 const char *target_strerror(int err)
 {
     if (err == TARGET_ERESTARTSYS) {