From: John Ferlan <jferlan@redhat.com>
Date: Fri, 18 Jan 2013 14:30:40 +0000 (-0500)
Subject: parallels: Need to handle virJSONValueObjectGetString error
X-Git-Tag: v1.0.2-rc1~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=1130fa3188f068351515a60fe1f5d2cb18d69e92;p=thirdparty%2Flibvirt.git

parallels: Need to handle virJSONValueObjectGetString error
---

diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
index ea193af72d..1b47246167 100644
--- a/src/parallels/parallels_driver.c
+++ b/src/parallels/parallels_driver.c
@@ -513,10 +513,9 @@ parallelsGetNetInfo(virDomainNetDefPtr net,
     }
 
     net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP;
-    if (virJSONValueObjectHasKey(value, "state")) {
-        tmp = virJSONValueObjectGetString(value, "state");
-        if STREQ(tmp, "disconnected")
-            net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
+    if ((tmp = virJSONValueObjectGetString(value, "state")) &&
+        STREQ(tmp, "disconnected")) {
+        net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
     }
 
     return 0;