From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Wed, 26 Mar 2025 20:54:04 +0000 (+0100)
Subject: optimize: incorrect comparison for reject statement
X-Git-Tag: v1.0.6.1~139
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=11471a51cec7e1f0429bff4dd44686fc91987bb9;p=thirdparty%2Fnftables.git

optimize: incorrect comparison for reject statement

commit abab6e60c755aef7e1ab9d3320effa714a0b49e2 upstream.

Logic is reverse, this should returns false if the compared reject
expressions are not the same.

Fixes: 38d48fe57fff ("optimize: fix reject statement")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/optimize.c b/src/optimize.c
index 8fc2b901..e200819c 100644
--- a/src/optimize.c
+++ b/src/optimize.c
@@ -232,7 +232,7 @@ static bool __stmt_type_eq(const struct stmt *stmt_a, const struct stmt *stmt_b,
 		if (!stmt_a->reject.expr)
 			return true;
 
-		if (__expr_cmp(stmt_a->reject.expr, stmt_b->reject.expr))
+		if (!__expr_cmp(stmt_a->reject.expr, stmt_b->reject.expr))
 			return false;
 		break;
 	case STMT_NAT: