From: Maud Spierings Date: Tue, 4 Mar 2025 08:14:52 +0000 (+0100) Subject: rtc: pcf85063: replace dev_err+return with return dev_err_probe X-Git-Tag: v6.15-rc1~33^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=119e90a3a64d9dd48bcf4c2d4fc13ba6bb7d940d;p=thirdparty%2Flinux.git rtc: pcf85063: replace dev_err+return with return dev_err_probe Replace the dev_err plus return combo with return dev_err_probe() this actually communicates the error type when it occurs and helps debugging hardware issues. Signed-off-by: Maud Spierings Link: https://lore.kernel.org/r/20250304-rtc_dev_err_probe-v1-1-9dcc042ad17e@gocontroll.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 73848f764559b..4fa5c4ecdd5a3 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -591,10 +591,8 @@ static int pcf85063_probe(struct i2c_client *client) i2c_set_clientdata(client, pcf85063); err = regmap_read(pcf85063->regmap, PCF85063_REG_SC, &tmp); - if (err) { - dev_err(&client->dev, "RTC chip is not present\n"); - return err; - } + if (err) + return dev_err_probe(&client->dev, err, "RTC chip is not present\n"); pcf85063->rtc = devm_rtc_allocate_device(&client->dev); if (IS_ERR(pcf85063->rtc))