From: Arne Schwabe Date: Mon, 25 Mar 2024 12:50:52 +0000 (+0100) Subject: Use snprintf instead of sprintf for get_ssl_library_version X-Git-Tag: v2.6.11~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=11ca69cfac1c6d3ed34652650688a4b3c99573b0;p=thirdparty%2Fopenvpn.git Use snprintf instead of sprintf for get_ssl_library_version This is avoid a warning/error (when using -Werror) under current macOS of sprintf: __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.") Change-Id: I3c6fd36eb9daee9244d6dc6d9f22de1c5cf9d039 Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240325125052.14135-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28458.html Signed-off-by: Gert Doering (cherry picked from commit 6a60d1bef424088df55f4d07efd45ce080fc7132) --- diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index 97c3cf2e6..08877f5eb 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1613,7 +1613,7 @@ get_ssl_library_version(void) { static char mbedtls_version[30]; unsigned int pv = mbedtls_version_get_number(); - sprintf( mbedtls_version, "mbed TLS %d.%d.%d", + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d", (pv>>24)&0xff, (pv>>16)&0xff, (pv>>8)&0xff ); return mbedtls_version; }