From: Jani Nikula Date: Fri, 10 May 2024 09:09:51 +0000 (+0300) Subject: drm: use "0" instead of "" for deprecated driver date X-Git-Tag: v6.11-rc1~141^2~24^2~178 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=11cdc8f2bde4bc548da6f995556c4b7183431088;p=thirdparty%2Flinux.git drm: use "0" instead of "" for deprecated driver date libdrm does not like the empty string for driver date. Use "0" instead, which has been used by virtio previously. Reported-by: Steven Price Closes: https://lore.kernel.org/r/9d0cff47-308e-4b11-a9f3-4157dc26b6fa@arm.com Fixes: 7fb8af6798e8 ("drm: deprecate driver date") Signed-off-by: Jani Nikula Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20240510090951.3398882-1-jani.nikula@intel.com Reviewed-by: Javier Martinez Canillas Tested-by: Steven Price Reviewed-by: Simon Ser --- diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 89feb7306e477..51f39912866fc 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -530,9 +530,9 @@ int drm_version(struct drm_device *dev, void *data, err = drm_copy_field(version->name, &version->name_len, dev->driver->name); - /* Driver date is deprecated. Return the empty string. */ + /* Driver date is deprecated. Userspace expects a non-empty string. */ if (!err) - err = drm_copy_field(version->date, &version->date_len, ""); + err = drm_copy_field(version->date, &version->date_len, "0"); if (!err) err = drm_copy_field(version->desc, &version->desc_len, dev->driver->desc);