From: Phil Sutter <phil@nwl.cc>
Date: Fri, 30 Sep 2022 22:17:50 +0000 (+0200)
Subject: extensions: libip6t_dst: Fix output for empty options
X-Git-Tag: v1.8.9~103
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=11e06cbb3a87739a3d958ba4c2f08fea7b100a68;p=thirdparty%2Fiptables.git

extensions: libip6t_dst: Fix output for empty options

If no --dst-opts were given, print_options() would print just a
whitespace.

Fixes: 73866357e4a7a ("iptables: do not print trailing whitespaces")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/extensions/libip6t_dst.c b/extensions/libip6t_dst.c
index bf0e3e43..baa010f5 100644
--- a/extensions/libip6t_dst.c
+++ b/extensions/libip6t_dst.c
@@ -125,15 +125,15 @@ static void
 print_options(unsigned int optsnr, uint16_t *optsp)
 {
 	unsigned int i;
+	char sep = ' ';
 
-	printf(" ");
 	for(i = 0; i < optsnr; i++) {
-		printf("%d", (optsp[i] & 0xFF00) >> 8);
+		printf("%c%d", sep, (optsp[i] & 0xFF00) >> 8);
 
 		if ((optsp[i] & 0x00FF) != 0x00FF)
 			printf(":%d", (optsp[i] & 0x00FF));
 
-		printf("%c", (i != optsnr - 1) ? ',' : ' ');
+		sep = ',';
 	}
 }